Add pos and length so that position in the loop can be determined#205
Merged
stephenhensley merged 8 commits intoelectro-smith:masterfrom May 29, 2025
Merged
Add pos and length so that position in the loop can be determined#205stephenhensley merged 8 commits intoelectro-smith:masterfrom
stephenhensley merged 8 commits intoelectro-smith:masterfrom
Conversation
Collaborator
|
Looks good to me! Definitely helpful additions! Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty simple getters I found useful to calculate where in the loop I am to display, I did not find IsNearBeginning to be sufficient for my needs.
I am using it like this
The formatting changes were so minor I thought it didn't impact the reviewability of the PR
Also added variable playback speed option