fix(nsis): Change the ProgID to a more correct, more unique format#9241
fix(nsis): Change the ProgID to a more correct, more unique format#9241sabonerune wants to merge 8 commits intoelectron-userland:masterfrom
Conversation
Based on this comment, this sounds like a Breaking change since we can't guarantee whether other custom NSIS scripts rely on this functionality. Curious on your thoughts? If we're aligned, then this will need to be pushed to the v27 release plans |
🦋 Changeset detectedLatest commit: 27a273a The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Changed changesets to major. I submitted this as a patch because the documentation does not explain how the name is used and how the ProgID is determined. However, considering that there is little information in the documentation for custom NSIS scripts, it may be better to make them major. |
fix #9229
Change the format of the ProgID to something more unique.
The format recommended by Microsoft is:
[Program].[Component].[Version]https://learn.microsoft.com/windows/win32/shell/fa-progids#programmatic-identifier-elements-used-by-file-associations
https://learn.microsoft.com/windows/win32/com/-progid--key
In this PR, we set it as follows:
This is useful if you have different versions of the same application installed at the same time, but electron
-builder doesn't seem to expect this.
UUID.v5(name || ext, guid)up to the maximum ProgID.I believe this will allow for the generation of unique ProgIDs while maintaining a certain degree of readability in the registry.
Is the Changeset patch correct?
I consider this change an undocumented, detailed behavior change in electron-builder.
However, custom NSIS scripts that expect the ProgID to be name or ext may no longer work correctly.