feat(electron-updater): Enhance download notification settings#9306
feat(electron-updater): Enhance download notification settings#9306Ashp116 wants to merge 16 commits intoelectron-userland:masterfrom
Conversation
🦋 Changeset detectedLatest commit: d8d4eb4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Love this! Can you please add a changeset via |
|
Hello @mmaietta, Great! I added a changeset for this PR. |
|
Hello @mmaietta, I am failing some of these checks, and I am not sure how to fix them. Could you assist me in resolving them? |
|
Getting back from vacation and revisiting this now. |
|
Hello @mmaietta, I changed the import for electron, but I'm not sure if it passes the failed workflows. The current workflows that are passing are fewer than the ones I had previously. |
|
Hello @mmaietta, I have updated the code to reflect the feedback. Actually I do agree that the |
|
Closing and reopening in #9472 so that I can make edits |
Description
This PR introduces more options
checkForUpdatesAndNotifymethod in electron-updater to provide more flexible download notification.Changes
downloadNotificationparameter now accepts:Notification- A custom Electron Notification instanceDownloadNotification- The existing notification configuration objectfalse- Explicitly disables notificationsNotificationclassUse Cases
Disable notifications
Custom Electron Notification
Default DownloadNotification