Open
Conversation
Helpful when options.name follows reverse DNS
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 210 210
=========================================
Hits 210 210
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been playing with the idea of switching to using reverse DNS for the name of my apps. When using any of the installers based on this module, if I set
options.nameto a reverse-DNS name, this also affects the symlink created by it.This might not always be the preferred behavior, so perhaps introducing a new option to set the name of the binary symlink might be a good idea.
The new option defaults to the same values as
options.name, so this shouldn't break anything. We will have to updatedesktop.ejsfor-debianand-redhat(perhaps other modules too?) to use the new option in theExec=field.Currently, I've named it
binNamebut I'm not set on the name, other ideas could be:symlink,symlinkName, orbinarySymlink