Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tweak a few more global git settings #690

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jan 28, 2025

From my latest Windows sync:

NORTHAMERICA+cavohr@CODEBYTERE-WIN-WORK CLANGARM64 ~/Developer/electron-gn/src/electron (main)
$ e sync -vvvv -f
Running "gclient sync --with_branch_heads --with_tags -vv -vvvv -f" in C:\Users\cavohr\Developer\electron-gn\src
Updating depot_tools...
WARNING:root:depot_tools recommends setting the following for
optimal Chromium development:

$ git config --global core.fscache true
$ git config --global core.preloadindex true

You can silence this message by setting these recommended values.

You can allow depot_tools to automatically update your global
Git config to recommended settings by running:
$ git config --global depot-tools.allowGlobalGitConfig true

To suppress this warning and silence future recommendations, run:
$ git config --global depot-tools.allowGlobalGitConfig false

@codebytere codebytere requested review from ckerr and a team as code owners January 28, 2025 20:38
@codebytere codebytere force-pushed the update-git-win-settings branch from 2020b7c to 9ce472a Compare January 28, 2025 20:39
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I pushed a commit to update the CI workflow for Windows, since we throw an error in maybeAutoFix in CI, so it was failing on Windows until that was updated.

@jkleinsc jkleinsc merged commit 80f5edb into main Jan 30, 2025
10 checks passed
@jkleinsc jkleinsc deleted the update-git-win-settings branch January 30, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants