fix: flaky utility and BrowserView tests #44451

samuelmaddock · 2024-10-29T15:31:15Z

fixes a few reoccurring flaky tests I noticed in #44411

Utility process checks for unique process name in crash details. Concurrent crashes can overlap causing problems. https://ci.appveyor.com/project/electron-bot/electron-woa-testing/builds/50882274/job/f4pqgi79du1fq2om/tests
BrowserView tests ensure no WebContents exist before and after each test. Concurrently running non-BrowserView tests might be throwing this off.

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant documentation, tutorials, templates and examples are changed or added
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Notes: none

ckerr

Nice, simple fix! LGTM

CC @jkleinsc as a stakeholder since he's also done some good test fixup lately

release-clerk · 2024-10-31T01:29:04Z

No Release Notes

samuelmaddock added 2 commits October 29, 2024 11:27

fix: flake wait for crash with specific serviceName

4c1329f

fix: flake when unrelated WebContents exists during BrowserView tests

e999b9a

samuelmaddock added the semver/none label Oct 29, 2024

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 29, 2024

samuelmaddock added the no-backport label Oct 29, 2024

samuelmaddock added 2 commits October 29, 2024 12:18

fix: wait for crash before forking

2e6da7e

use name

8061513

ckerr approved these changes Oct 29, 2024

View reviewed changes

VerteDinde approved these changes Oct 29, 2024

View reviewed changes

codebytere approved these changes Oct 30, 2024

View reviewed changes

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 30, 2024

ckerr merged commit 31f8e75 into main Oct 31, 2024
50 checks passed

ckerr deleted the fix/utility-flaky-tests branch October 31, 2024 01:29

Provide feedback