refactor: move more of start fiddle flow to main process#1935
Open
dsanders11 wants to merge 26 commits into
Open
refactor: move more of start fiddle flow to main process#1935dsanders11 wants to merge 26 commits into
dsanders11 wants to merge 26 commits into
Conversation
|
coverage: 88.235% (-0.2%) from 88.468% — build/refactor-start-fiddle-ipc into main |
ckerr
approved these changes
May 7, 2026
Member
Author
|
Note that 6c4a09f is a drive by fix for an existing bug since I was in the area and it annoyed me. |
dsanders11
force-pushed
the
build/refactor-start-fiddle-ipc
branch
from
bd0c2fe to
ee4e03c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when a fiddle is started, the
START_FIDDLEIPC event is sent from the renderer to the main process, with all the parameters needed to start the fiddle. This PR changes the flow to drop the parameters onSTART_FIDDLEand instead add a newGET_START_FIDDLE_OPTIONSIPC request from main -> renderer to get those parameters. This lets us decouple the starting of a fiddle and will let us isolate the run button.This also lets us consolidate more of the run fiddle logic into the main process and simplifies the flow instead of having a split brain where the renderer was driving some of the process. As a result we can drop the
CLEANUP_DIRECTORYandDELETE_USER_DATAIPC events.