-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove graceful-fs
and use direct imports
#229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read through the linked PR, changes look good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has better tests than #228 did 👍
Co-authored-by: Mark Lee <[email protected]>
@ckerr Yeah, I think I wasn't very judicious in the original #222 PR and did blanket replacements for Reading through the code when investigating the bug led me to find that we aren't using any functions that |
🎉 This PR is included in version 3.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #227
Uses
node:fs
directly instead of routinggraceful-fs
throughutil.promisify
.import * as fs from 'graceful-fs'
would make thefs
syntax look likefs.default.fn()
instead offs.fn()
.graceful-fs
doesn't patchfs.rm
norfs.mkdtemp
, so it's safe to remove the package altogether and preserve previous behaviour.withTempDir
helper, although I thinkvitest
magic makes it so that the test passes even with the faulty runtime import.cc @ckerr @erikian