Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shortcut-icon url in header #95

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: shortcut-icon url in header #95

wants to merge 1 commit into from
+1 −1

Conversation

me-mahmads
Copy link

This PR Fixes: #94 (invalid shortcut-url in header).
Updated the favicon.ico to new url from electron official website

@me-mahmads me-mahmads requested review from a team as code owners March 20, 2025 09:36
erickzhao
erickzhao requested changes Mar 20, 2025
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @me-mahmads, this change LGTM. However, this repo requires that you sign your commits. Can you sign your commits and force push back onto your branch?

@me-mahmads
Copy link
Author

Thanks for introducing "signing commits", I have signed the commit.

@me-mahmads me-mahmads force-pushed the main branch 3 times, most recently from ff22375 to 36ff82b Compare March 20, 2025 20:34
@me-mahmads me-mahmads requested a review from erickzhao March 20, 2025 21:13
@me-mahmads
Copy link
Author

The Latest commit also Fixes #97
Changes Made
Adjusted the condition in the logic to check explicitly for null values rather than treating 0 as invalid.

Steps to Reproduce the Original Issue
Navigate to the releases page.
Observe that versions with major = 0 are not displayed correctly.
This fix ensures that major = 0 is correctly processed.

nikwen
nikwen requested changes Mar 21, 2025
View reviewed changes
Copy link
Member

@nikwen nikwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for signing the commit!

Could you please create a separate pull request for the second commit? (I.e. remove the second commit again from this pull request and open a separate pull request for it?)

Every pull request should be limited to one fix or one feature.

@me-mahmads
Copy link
Author

Sorry for disturbance. I have removed the commit from this PR. Thanks.

nikwen
nikwen approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@nikwen nikwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikwen nikwen nikwen approved these changes

@erickzhao erickzhao erickzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid shortcut-icon url
3 participants
@me-mahmads @nikwen @erickzhao