Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always create backport check run #253

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

dsanders11
Copy link
Member

Fixes #251.

There's currently several cases where the backport check run for a target branch can be out-of-sync (or missing altogether) with trop's backport attempts. This PR aims to ensure there's always a check run when trop is executing a backport, and that it's always updated with the outcome of that backport execution attempt. This should ensure that a failure to backport after the PR is merged won't have a conflicting state where the check run (done when the PR was labeled) is clean.

@dsanders11 dsanders11 requested a review from a team as a code owner March 23, 2023 20:10
@codebytere codebytere self-requested a review May 31, 2023 20:51
@dsanders11 dsanders11 merged commit 3a7af43 into electron:main Apr 5, 2024
3 checks passed
@dsanders11 dsanders11 deleted the always-create-check branch April 5, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Backport Failure Details on Trop Commands
3 participants