Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make Node.js version more explicit #493

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

erickzhao
Copy link
Member

Matches what we're building in CI.

@erickzhao erickzhao requested a review from a team as a code owner January 12, 2024 20:01
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-493 January 12, 2024 20:02 Inactive
@erickzhao erickzhao force-pushed the chore/make-node-version-more-explicit branch from 00af51d to 45007c0 Compare January 12, 2024 20:02
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-493 January 12, 2024 20:02 Inactive
@dsanders11
Copy link
Member

I know this is just documenting the current reality, but we should upgrade to Node 18+ since 16 is EOL. 🙂

@codebytere codebytere merged commit 40d22e3 into main Jan 15, 2024
3 checks passed
@codebytere codebytere deleted the chore/make-node-version-more-explicit branch January 15, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants