fix: logo icon briefly disappears and reappears during theme change #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…during theme change
BlackHole1
changed the title
BlackHole1
requested changes
Mar 27, 2024
add space line at the end of file Co-authored-by: Kevin Cui <[email protected]>
Modify comments, links to issue 539 Co-authored-by: Kevin Cui <[email protected]>
|
Hi @BlackHole1, I have applied the requested changes. Thank you so much for the suggestions! |
dsanders11
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #539.
Current Behavior: the logo still blinks sometimes when changing theme, but the layout would not be messed up. This is the same behavior as https://docusaurus.io/docs
Built and tested on my local environment (windows, chrome) with different window sizes.
Related: facebook/docusaurus#8188