blog: mention background color on WebContentsView #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the `WebContentsView` migration guide/blog post did not mention the changed default background color of `WebContentsView` compared to `BrowserView`'s, this adds a note about that.
erickzhao
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Thanks for this @KiruPoruno and @nikwen! I pushed up a commit to do some minor copy-editing but this LGTM.
erickzhao
changed the title
|
Thanks for the PR and for the copy changes. Looks good to me in its current form! 👍 |
Co-authored-by: Charles Kerr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
WebContentsViewmigration guide/blog post did not mention the changed default background color ofWebContentsViewcompared toBrowserView's, this adds a note about that.Closes electron/#44914