Skip to content

[Snyk] Fix for 1 vulnerabilities#751

Open
lots0logs wants to merge 1 commit into
masterfrom
snyk-fix-53a0f5c7db04a5aa4366ae0574b60b18
Open

[Snyk] Fix for 1 vulnerabilities#751
lots0logs wants to merge 1 commit into
masterfrom
snyk-fix-53a0f5c7db04a5aa4366ae0574b60b18

Conversation

@lots0logs
Copy link
Copy Markdown
Member

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • packages/divi-scripts/package.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Prototype Pollution
SNYK-JS-JSYAML-13961110
  631  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Prototype Pollution

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates two npm dependencies in the divi-scripts package to address a Prototype Pollution vulnerability (SNYK-JS-JSYAML-13961110) in js-yaml, a transitive dependency.

  • Updates css-loader from 0.28.9 to 1.0.0 (major version bump)
  • Updates grunt from 1.0.2 to 1.2.0 (minor version bump)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"case-sensitive-paths-webpack-plugin": "2.1.1",
"chalk": "2.3.0",
"css-loader": "0.28.9",
"css-loader": "1.0.0",
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upgrade to css-loader 1.0.0 introduces a breaking change. The minimize option was removed in css-loader 1.0.0 and moved to optimization configuration. The webpack configuration files (webpack.config.prod.js) currently use minimize: true in the css-loader options (lines 323, 362, 397), which will cause build failures.

To fix this, the minimize option should be removed from css-loader options and handled through webpack's optimization configuration instead, or the webpack config files should be updated accordingly.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants