Reset overwrite url if it is invalid (does fail to reach sfu) #3595
+45
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
added
the
PR-Developer-Experience
Half-Shot
requested changes
Nov 27, 2025
| const [customLivekitUrl, setCustomLivekitUrl] = useSetting( | ||
| customLivekitUrlSetting, | ||
| ); | ||
| const [customLivekitUrl, setCustomLivekitUrl, customLivekitUrlUpdateReason] = |
Member
There was a problem hiding this comment.
Can we test it here somehow, even just a basic attempt to auth? We can do nicer UX here and set the input to busy, let it run to test whether the URL works and that way the URL doesn't change unexpectedly. We can also show a nice error string :)
Contributor
Author
There was a problem hiding this comment.
Do you think this is worthit for a dev tool? I almost though i am doing too nice ux for a devtool
Member
There was a problem hiding this comment.
Well, if it was a days effort then maybe but this should a relatively trivial bit of code. I think even devs should have a nice experience :)
toger5
force-pushed
the
toger5/dont-trap-in-invalid-config
branch
from
8348e94 to
4148a05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overwrite option currently can brick your element call and you need to update the local store manually. This PR automatically resets the overwrite url if it errored once while trying to get the livekit focus. (auto fallback to nen dev overwrite)