Skip to content

Conversation

@Half-Shot
Copy link
Member

This introduces more Element Call tests, this time using a fake Element Call widget that does just enough to enable PiP. This should be useful enough to know if we're doing things like cleaning up the widgets appropriately.

This will be modified to fail on purpose to test the problem being fixed by #31314

Checklist

@Half-Shot Half-Shot marked this pull request as ready for review November 28, 2025 12:19
@Half-Shot Half-Shot requested review from a team as code owners November 28, 2025 12:19
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magnifique 🥇

const pipContainer = page.locator(".mx_WidgetPip");

// We should have a PiP container here.
await expect(pipContainer).toBeVisible();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this test may be flaky based on the annotation left here by CI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot. Looks like occasionally we get swapped back to the old room after clicking on a room in the room list, more to investigate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put in an extra test on the UI that Element has picked up the video call before we switch rooms, which hopefully prevents it from doing that odd switching behaviour.

@Half-Shot Half-Shot self-assigned this Nov 28, 2025
@Half-Shot Half-Shot requested a review from t3chguy November 28, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Task Tasks for the team like planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants