-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Implement Playwright tests to ensure calls persist across room switches #31354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
BillCarsonFr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Magnifique 🥇
| const pipContainer = page.locator(".mx_WidgetPip"); | ||
|
|
||
| // We should have a PiP container here. | ||
| await expect(pipContainer).toBeVisible(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this test may be flaky based on the annotation left here by CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good spot. Looks like occasionally we get swapped back to the old room after clicking on a room in the room list, more to investigate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put in an extra test on the UI that Element has picked up the video call before we switch rooms, which hopefully prevents it from doing that odd switching behaviour.
This introduces more Element Call tests, this time using a fake Element Call widget that does just enough to enable PiP. This should be useful enough to know if we're doing things like cleaning up the widgets appropriately.
This will be modified to fail on purpose to test the problem being fixed by #31314
Checklist
public/exportedsymbols have accurate TSDoc documentation.