Skip to content

Conversation

@rbondesson
Copy link
Contributor

@rbondesson rbondesson commented Jan 29, 2026

Checklist

Move EventTileBubble to shared-components

Summary

  • Moved EventTileBubble component to @element-hq/web-shared-components package as EventTileBubble

Changes

New shared component

Added EventTileBubble under packages/shared-components/src/event-tiles/EventTileBubble/ with:

  • CSS module for styling
  • Storybook stories for visual testing
  • Unit tests with snapshot coverage

Codebase migration

  • WaitingForThirdPartyRoomView.tsx: Now renders EventTileBubble instead of the old component
  • EncryptionEvent.tsx: Now renders EventTileBubble instead of the old component
  • MJitsiWidgetEvent.tsx: Now renders EventTileBubble instead of the old component
  • MKeyVerificationRequest.tsx: Now renders EventTileBubble instead of the old component
  • RoomPredecessorTile.tsx: Now renders EventTileBubble instead of the old component
  • HistoryTile.tsx: Now renders EventTileBubble instead of the old component
  • NewRoomIntro.tsx: Now renders EventTileBubble instead of the old component
  • Moved the css global variable --EventTileBubble_margin-block: 10px; to _common.pcss
  • Changed font-size for subtitles from $font-12px (0.75rem) to --cpd-font-size-body-sm (0.8125rem) - there is no equivalent font size in compound.
  • Changed padding for the container from 10px to --cpd-space-3x (12px) - there is no equivalent padding in compound.

Test plan

  • Verify event tile bubble renders correctly in rooms
  • Run new unit tests: yarn test:unit "EventTileBubble" -u
  • Run unit tests for affected components in element-web
  • Check Storybook stories render correctly

Tests

image image image image

Before & After

  • Before Refactoring
image
  • After Refactoring
image

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally sane other than the nits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Task Tasks for the team like planning Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants