Skip to content

Comments

Update URL Preview playwright tests to use new endpoint#32573

Open
Half-Shot wants to merge 6 commits intodevelopfrom
hs/update-media-prefix
Open

Update URL Preview playwright tests to use new endpoint#32573
Half-Shot wants to merge 6 commits intodevelopfrom
hs/update-media-prefix

Conversation

@Half-Shot
Copy link
Member

For matrix-org/matrix-js-sdk#5191

Checklist

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks sad

).toBeVisible();
});

test("should render url previews", { tag: "@screenshot" }, async ({ page, app, room, axe, context }) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped this as it seemed duplicated with my tests, and I've selfishly taken mine because:

  1. I've somehow made this works without hax.
  2. We test both thumbnail and thumbnailess previews.

I've incorporated axe into my tests.

t3chguy
t3chguy approved these changes Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Task Tasks for the team like planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants