Unified media preview 4 - upload confirm dialog uses the previews - #34892
Open
Siriusmart wants to merge 27 commits into
Open
Unified media preview 4 - upload confirm dialog uses the previews#34892Siriusmart wants to merge 27 commits into
Siriusmart wants to merge 27 commits into
Conversation
Siriusmart
requested review from
Half-Shot and
florianduros
and removed request for
a team
September 1, 2026 14:08
Siriusmart
force-pushed
the
unified-previews/3-url-preview-tile
branch
from
September 1, 2026 14:52
3e3d482 to
d5ac054
Compare
Siriusmart
force-pushed
the
unified-previews/4-upload-confirm-dialog
branch
from
September 1, 2026 14:52
ff8a31b to
77d8250
Compare
…ews/4-upload-confirm-dialog
…ews/4-upload-confirm-dialog
…ews/4-upload-confirm-dialog
computePreviewContent only ever ran its image case: the video, audio and plain-file cases were untested. Claude-Session: https://claude.ai/code/session_01Gr8zCXinjjNTmAHpZDGNtW
…ews/4-upload-confirm-dialog
florianduros
requested changes
Sep 2, 2026
t3chguy
added
the
X-Needs-Iteration
github-actions
Bot
removed
the
X-Needs-Iteration
…ews/4-upload-confirm-dialog
…ews/4-upload-confirm-dialog
…ews/4-upload-confirm-dialog
The entry discriminator is now `type` rather than `style`, and image entries must carry `imageAlt` — the upload preview labels it with the file name, matching the accessible name the pre-existing dialog gave the image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.