Tweak Banner module styling - #34903
Conversation
Also improve docs + Documents `theme` key + Wraps the heading title in the anchor + Tweaks the default width of the trigger to 69px to match the space panel with its border. + Fixes focus lingering Bumps version in preparation of release
|
I don't think we need to block on design review here, I'm happy to 'tick' in their place. The screenshots look good and appear to match their figma and our duplicate of their figma. One thing though -- might just be config, their 'app name' is "Chat" not "Element". Would this change in their hosted thing because they've got different app names already available? |
|
@daniellekirkwood the title uses a module-specific config, falling back to |
|
thanks @t3chguy -- so in their environment it would be "chat" ??? |
|
It would be whatever they configure to be, |
|
So "yes" then |
daniellekirkwood
left a comment
daniellekirkwood
left a comment
There was a problem hiding this comment.
on behalf of design because this looks like it matches the figma and we can always tweak it later
…o t3chguy/iterate-banner # Conflicts: # pnpm-lock.yaml
4 participants
Also improve docs
themekeyBumps version in preparation of release
Closes https://github.com/element-hq/wat-internal/issues/523
Closes https://github.com/element-hq/wat-internal/issues/524
Closes #34924
Based on https://www.figma.com/design/5tye5cpht6NFc4RaV0fJl0/ER-169---OpenDesk-Top-Bar-Functionality?node-id=232-22520&t=txIiEnvqojH6Z9gb-0
For https://github.com/element-hq/customer-success/issues/356