Skip to content

Conversation

@ganfra
Copy link
Member

@ganfra ganfra commented Dec 29, 2025

Content

Remove the Space feature flag entirely.

On a follow-up PR, we might want to returns the default value (or true) when a feature is marked as finished, to avoid having previous values interfering.

Motivation and context

Clean up code.
Makes sure space tab is visible.

Screenshots / GIFs

No ui change.

Tests

  • Disable the space feature flag from an old version of the app
  • Update to this PR version
  • Check space tab is visible as long as you have joined at least one space.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@ganfra ganfra added PR-Misc For other changes PR-Bugfix For bug fix labels Dec 29, 2025
@ganfra ganfra marked this pull request as ready for review December 29, 2025 19:50
@ganfra ganfra requested a review from a team as a code owner December 29, 2025 19:50
@ganfra ganfra requested review from jmartinesp and removed request for a team December 29, 2025 19:50
@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/FAmbbd

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Bugfix For bug fix PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants