Skip to content

Take into account the value of FeatureFlags.SignInWithClassic#6586

Merged
bmarty merged 1 commit intodevelopfrom
feature/bma/useSignInWithClassicFlag
Apr 15, 2026
Merged

Take into account the value of FeatureFlags.SignInWithClassic#6586
bmarty merged 1 commit intodevelopfrom
feature/bma/useSignInWithClassicFlag

Conversation

@bmarty
Copy link
Copy Markdown
Member

@bmarty bmarty commented Apr 15, 2026

After many reworks, it appears that the feature flags ended up not being used. This PR should fix that.

Related to #6296

@bmarty bmarty requested a review from a team as a code owner April 15, 2026 10:05
@bmarty bmarty requested review from jmartinesp and removed request for a team April 15, 2026 10:05
@bmarty bmarty added the PR-Misc For other changes label Apr 15, 2026
@sonarqubecloud
Copy link
Copy Markdown

@ElementBot
Copy link
Copy Markdown
Collaborator

Warnings
⚠️

features/login/impl/src/main/kotlin/io/element/android/features/login/impl/classic/ElementClassicConnection.kt#L218 - This Handler class should be static or leaks might occur (io.element.android.features.login.impl.classic.DefaultElementClassicConnection.IncomingHandler)

Generated by 🚫 dangerJS against e4bee73

Copy link
Copy Markdown
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.10%. Comparing base (897c68e) to head (e4bee73).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...res/login/impl/classic/ElementClassicConnection.kt 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6586      +/-   ##
===========================================
- Coverage    81.10%   81.10%   -0.01%     
===========================================
  Files         2605     2605              
  Lines        72266    72272       +6     
  Branches      9364     9366       +2     
===========================================
+ Hits         58610    58614       +4     
- Misses       10212    10213       +1     
- Partials      3444     3445       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/f1t37H

@bmarty bmarty merged commit be775d6 into develop Apr 15, 2026
38 of 39 checks passed
@bmarty bmarty deleted the feature/bma/useSignInWithClassicFlag branch April 15, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants