Skip to content

Split developer settings into 2 screens to be able to access global settings when no logged in.#6587

Merged
bmarty merged 3 commits intodevelopfrom
feature/bma/flagsFromOnBoarding
Apr 15, 2026
Merged

Split developer settings into 2 screens to be able to access global settings when no logged in.#6587
bmarty merged 3 commits intodevelopfrom
feature/bma/flagsFromOnBoarding

Conversation

@bmarty
Copy link
Copy Markdown
Member

@bmarty bmarty commented Apr 15, 2026

Content

Extract global settings (i.e. not related to a Matrix session) from developer settings screen, to be able to have an AppScope Node with the global settings, accessible when the user is not logged in yet.

Motivation and context

Be able to tweak feature flags and Rust trace level without being logged in. Helpful to change flags related to the login flow.

Screenshots / GIFs

See recorded screenshots and:

Screen_recording_20260415_121326.mp4

Tests

  • Install and start the app
  • you should see a settings icon at top start of the screen, if not in release build.
  • click it
  • you should be able to tweak FF and Rust log level.
  • log in to the app
  • navigate to the developer settings
  • all the settings are here, a bit reordered (the global settings are rendered first)

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner April 15, 2026 10:19
@bmarty bmarty requested review from ganfra and removed request for a team April 15, 2026 10:19
@bmarty bmarty added the PR-Misc For other changes label Apr 15, 2026
Copy link
Copy Markdown
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@bmarty bmarty enabled auto-merge April 15, 2026 10:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/5Pkwhc

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 89.39394% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.08%. Comparing base (b6188a7) to head (8503d1c).
⚠️ Report is 20 commits behind head on develop.

Files with missing lines Patch % Lines
...loper/appsettings/AppDeveloperSettingsPresenter.kt 88.13% 1 Missing and 6 partials ⚠️
.../developer/appsettings/AppDeveloperSettingsView.kt 91.80% 1 Missing and 4 partials ⚠️
...s/preferences/impl/DefaultPreferencesEntryPoint.kt 0.00% 3 Missing ⚠️
...ures/preferences/test/FakePreferencesEntryPoint.kt 33.33% 2 Missing ⚠️
...gin/impl/screens/onboarding/OnBoardingPresenter.kt 0.00% 0 Missing and 1 partial ⚠️
...developer/appsettings/AppDeveloperSettingsEvent.kt 75.00% 1 Missing ⚠️
.../developer/appsettings/AppDeveloperSettingsPage.kt 92.85% 0 Missing and 1 partial ⚠️
...ences/impl/developer/di/DeveloperSettingsModule.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6587   +/-   ##
========================================
  Coverage    81.07%   81.08%           
========================================
  Files         2604     2612    +8     
  Lines        72128    72193   +65     
  Branches      9348     9351    +3     
========================================
+ Hits         58479    58535   +56     
- Misses       10212    10218    +6     
- Partials      3437     3440    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty disabled auto-merge April 15, 2026 14:16
@bmarty bmarty merged commit 9699488 into develop Apr 15, 2026
32 of 33 checks passed
@bmarty bmarty deleted the feature/bma/flagsFromOnBoarding branch April 15, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants