Skip to content

Add an AccountProvider type and use it within the authentication flow. - #6103

Draft
pixlwave wants to merge 2 commits into
developfrom
doug/account-provider
Draft

Add an AccountProvider type and use it within the authentication flow.#6103
pixlwave wants to merge 2 commits into
developfrom
doug/account-provider

Conversation

@pixlwave

@pixlwave pixlwave commented Sep 3, 2026

Copy link
Copy Markdown
Member

This PR makes 3 changes:

  • Adds a dedicated AccountProvider type instead of using a plain String for app configuration.
    • Used in both AppSettings and LoginHomeserver (the latter for display sanitisation).
  • Reinstates the checks for allowed servers when using QR code login (removed in #5196)
  • Renames any remaining uses of homeserverAddress to serverNameOrBaseURL.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

PR Checks

  • ⚠️ You seem to have made changes to views. Please consider adding screenshots.

@pixlwave pixlwave added the pr-change for updates to an existing feature label Sep 3, 2026
@pixlwave pixlwave changed the title Add an AccountProvider type and use it within the authentication flow. Add an AccountProvider type and use it within the authentication flow. Sep 3, 2026
@pixlwave
pixlwave force-pushed the doug/account-provider branch from 18cbda5 to 625b48a Compare September 3, 2026 15:38
@pixlwave
pixlwave force-pushed the doug/account-provider branch from 625b48a to ba0f8fc Compare September 4, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-change for updates to an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant