Detect home server from matrix id#810
Open
Kaki-In wants to merge 22 commits into
Open
Conversation
…host) in the username input when logging in, without having to update the server hostname on the first input
bwindels
reviewed
Jul 25, 2022
Contributor
bwindels
left a comment
bwindels
left a comment
There was a problem hiding this comment.
Just a few comments, haven't done a full review yet.
…s) : - fix methods miss; - corrected some identation mistakes.
PasswordLoginViewModel.parseUsernameLogin() should return the username, not the servername.
Member
MidhunSureshR
left a comment
MidhunSureshR
left a comment
There was a problem hiding this comment.
Some comments and questions:
Fix all the new comments inside element-hq#810 (review)
bwindels
reviewed
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect home server from matrix id
Added functionnality :
Should fix this issue (#479).