Scrolling with the main log in view#817
Open
Kaki-In wants to merge 8 commits into
Open
Conversation
bwindels
reviewed
Jul 29, 2022
Contributor
bwindels
left a comment
bwindels
left a comment
There was a problem hiding this comment.
Looks ok, need to look more into it. For now just a comment with an idea to simplify.
|
|
||
| @media screen and (min-width: 600px) { | ||
| .PreSessionScreen { | ||
| max-height: calc(100% - 30px - 80px); /* removing padding and margin */ |
Contributor
There was a problem hiding this comment.
Just an idea, but would this be simpler if we use box-sizing: content-box?
Contributor
Author
There was a problem hiding this comment.
it doesn't work because of the margin, I still need to had the @media.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrolling on the main log view
Technical changes :
PreSessionScreento overflow him and be scrolled;Should fix this issue (783)