Skip to content

fix normalizing of homeserver#964

Open
ashfame wants to merge 2 commits into
element-hq:masterfrom
Automattic:fix-normalizing-of-homeserver
Open

fix normalizing of homeserver#964
ashfame wants to merge 2 commits into
element-hq:masterfrom
Automattic:fix-normalizing-of-homeserver

Conversation

@ashfame
Copy link
Copy Markdown

@ashfame ashfame commented Dec 19, 2022

PR fixes the normalizing approach towards homeserver.

Before this PR, function wasn't able to normalize synapse.dev:8008 homeserver correctly.

Here is the output prior to this PR:

"synapse.dev" -> "https://synapse.dev"
"synapse.dev:8008" -> "null"
"https://matrix.org" -> "https://matrix.org"
"https://matrix.org:8080" -> "https://matrix.org:8080"
"http:// invalid" -> "https://http"

With the changes in PR, the output is as follows:

"synapse.dev" -> "https://synapse.dev"
"synapse.dev:8008" -> "https://synapse.dev:8008"
"https://matrix.org" -> "https://matrix.org"
"https://matrix.org:8080" -> "https://matrix.org:8080"
"http:// invalid" -> ""

Signed-off-by: Ashish Kumar ashfame@users.noreply.github.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant