Add error handling and place a lock over DM map updates#72
Draft
reivilibre wants to merge 5 commits into
Draft
Conversation
Failed unexpectedly in conf-bot CI, this should fix it. Unable to reproduce locally. src/appservice/Appservice.ts(342,16): error TS2742: The inferred type of 'expressAppInstance' cannot be named without a reference to '.bin/store/v10/tmp/_tmp_2138_bf24043bb4cf978a70c5cda060d7e1d0/node_modules/@types/express-serve-static-core'. This is likely not portable. A type annotation is necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a branch that we are using in the Conference Bot. I am opening it as a draft here so we can keep at least a little track of it.
Only the Add error handling and place a lock over DM map updates commit is an intended fix that we needed, I think.
Checklist