Skip to content

Point out which event caused the exception when checking MSC4293 redactions#19169

Merged
MadLittleMods merged 7 commits into
developfrom
madlittlemods/19128-better-error-when-json-load-fails
Nov 13, 2025
Merged

Point out which event caused the exception when checking MSC4293 redactions#19169
MadLittleMods merged 7 commits into
developfrom
madlittlemods/19128-better-error-when-json-load-fails

Conversation

@MadLittleMods
Copy link
Copy Markdown
Contributor

@MadLittleMods MadLittleMods commented Nov 12, 2025 •
edited
Loading

Point out which event caused the exception when checking MSC4293 redactions.

Spawning from looking at the stack trace in #19128 which has no useful information on how to dig in deeper.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

MadLittleMods
MadLittleMods commented Nov 12, 2025
View reviewed changes
Comment thread synapse/storage/databases/main/events_worker.py Outdated
@MadLittleMods MadLittleMods changed the title Point out which event caused the exception when checking MSC4932 redactions Point out which event caused the exception when checking MSC4293 redactions Nov 12, 2025
MadLittleMods
MadLittleMods commented Nov 12, 2025
View reviewed changes
Comment thread synapse/storage/databases/main/events_worker.py
d.redactions.append(redacter)

# check for MSC4932 redactions
# check for MSC4293 redactions
Copy link
Copy Markdown
Contributor Author

@MadLittleMods MadLittleMods Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this code was added in #18540 and this is the correct MSC number -> MSC4293

@MadLittleMods MadLittleMods mentioned this pull request Nov 12, 2025
Closed
@MadLittleMods MadLittleMods marked this pull request as ready for review November 12, 2025 20:30
@MadLittleMods MadLittleMods requested a review from a team as a code owner November 12, 2025 20:30
reivilibre
reivilibre approved these changes Nov 13, 2025
View reviewed changes
Comment thread synapse/storage/databases/main/events_worker.py Outdated
MadLittleMods and others added 3 commits November 13, 2025 09:55
@MadLittleMods @reivilibre
Use f-string formatting
077030e 
Co-authored-by: reivilibre <oliverw@element.io>
@MadLittleMods
Merge branch 'develop' into madlittlemods/19128-better-error-when-jso…
d92c6d3 
…n-load-fails
@MadLittleMods
Merge branch 'madlittlemods/19128-better-error-when-json-load-fails' …
f248806 
…of github.com:element-hq/synapse into madlittlemods/19128-better-error-when-json-load-fails
@MadLittleMods MadLittleMods merged commit 4494cc0 into develop Nov 13, 2025
41 of 45 checks passed
@MadLittleMods MadLittleMods deleted the madlittlemods/19128-better-error-when-json-load-fails branch November 13, 2025 18:08
@MadLittleMods
Copy link
Copy Markdown
Contributor Author

MadLittleMods commented Nov 13, 2025

Thanks for the review @reivilibre 🦜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reivilibre reivilibre reivilibre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MadLittleMods @reivilibre