Feat/gcp json formatter#19775
Open
shcherbak wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Synapse runs on GKE, all log entries appear in Google Cloud Logging with severity: ERROR, regardless of the actual Python log level. This happens because GKE's logging agent automatically
assigns ERROR to anything written to stderr.
Switching to stdout alone is not sufficient: GCL and the underlying fluentbit/fluentd agents recognise the severity JSON field specifically. The existing JsonFormatter and TerseJsonFormatter
both emit "level", which is not mapped automatically.
Fix
Add GcpJsonFormatter to synapse.logging. It outputs one JSON line per record with the four fields GCL expects:
Usage in log_config.yaml: