Update `HomeserverTestCase.get_success(...)` and friends to drive async Rust (Tokio runtime/thread pool)#19871

Draft

MadLittleMods wants to merge 30 commits into

developfrom

madlittlemods/better-get-success

Commits on Jun 20, 2026

Fix `tests/storage/test_background_update.py`
MadLittleMods
committed
Fix `tests/app/test_homeserver_shutdown.py`
MadLittleMods
committed
Fix `tests/handlers/test_presence.py`
MadLittleMods
committed
Fix `tests/handlers/test_send_email.py`
MadLittleMods
committed
Explain why remove `get_success_or_raise`
MadLittleMods
committed
Extract logic to `_wait_for_deferred`
MadLittleMods
committed
Fix FIXME comment grammar
MadLittleMods
committed
Use 1 second timeout default
MadLittleMods
committed
Use "deferred" in `_wait_for_deferred` docstring
MadLittleMods
committed
Add example if you need to advance time
MadLittleMods
committed
Fix `tests.handlers.test_profile.ProfileTestCase.test_background_update_room_membership_resume_after_restart`
MadLittleMods
committed
No need to change background update in `tests/app/test_homeserver_shutdown.py`
MadLittleMods
committed
Fix `tests.handlers.test_user_directory.UserDirectoryTestCase.test_process_join_after_server_leaves_room`
MadLittleMods
committed
Fix `tests/handlers/test_typing.py`
MadLittleMods
committed
Fix `trial tests.replication.test_federation_ack`
MadLittleMods
committed
Fix lints
MadLittleMods
committed
Merge branch 'develop' into madlittlemods/better-get-success
MadLittleMods
committed
Remove other `till_deferred_has_result`
MadLittleMods
committed
Explain better
MadLittleMods
committed
Fix `tests.storage.databases.main.test_events_worker.GetEventCancellationTestCase.test_first_get_event_cancelled`
MadLittleMods
committed
Remove `wait_on_thread`
MadLittleMods
committed
Fix `trial-olddeps`: `builtins.TypeError: 'type' object is not subscriptable`
MadLittleMods
committed
Fix `tests.replication.tcp.test_handler.ChannelsTestCase.test_wait_for_stream_position_rdata`
MadLittleMods
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `HomeserverTestCase.get_success(...)` and friends to drive async Rust (Tokio runtime/thread pool)#19871

Update `HomeserverTestCase.get_success(...)` and friends to drive async Rust (Tokio runtime/thread pool)#19871
MadLittleMods wants to merge 30 commits into
developfrom
madlittlemods/better-get-success

Commits on Jun 19, 2026

Refactor `get_success(...)` to allow other threads to make progress

Refactor `get_failure`

Fix `get_failure(...)` raises docstring

Add changelog

Fix `get_failure` lint

Reduce timeout so you don't have to wait as long when something goes wrong

Fix test cases that don't need `by=`

Commits on Jun 20, 2026

Fix `tests/storage/test_background_update.py`

Fix `tests/app/test_homeserver_shutdown.py`

Fix `tests/handlers/test_presence.py`

Fix `tests/handlers/test_send_email.py`

Explain why remove `get_success_or_raise`

Extract logic to `_wait_for_deferred`

Fix FIXME comment grammar

Use 1 second timeout default

Use "deferred" in `_wait_for_deferred` docstring

Add example if you need to advance time

Fix `tests.handlers.test_profile.ProfileTestCase.test_background_update_room_membership_resume_after_restart`

No need to change background update in `tests/app/test_homeserver_shutdown.py`

Fix `tests.handlers.test_user_directory.UserDirectoryTestCase.test_process_join_after_server_leaves_room`

Fix `tests/handlers/test_typing.py`

Fix `trial tests.replication.test_federation_ack`

Fix lints

Merge branch 'develop' into madlittlemods/better-get-success

Remove other `till_deferred_has_result`

Explain better

Fix `tests.storage.databases.main.test_events_worker.GetEventCancellationTestCase.test_first_get_event_cancelled`

Remove `wait_on_thread`

Fix `trial-olddeps`: `builtins.TypeError: 'type' object is not subscriptable`

Fix `tests.replication.tcp.test_handler.ChannelsTestCase.test_wait_for_stream_position_rdata`