soversioning #195
soversioning #195
Conversation
|
This was the latest review: (In reply to Ryan H. Lewis (rhl) from comment #11)
< $ mock -r fedora-rawhide-x86_64 --no-clean --shell 'rpm -q --list elemental-mpich| grep lib64' '/usr/lib64/mpich/lib/libEl.so' and '/usr/lib64/openmpi/lib/libEl.so' must be packed in 'elemental-mpich-devel' and 'elemental-openmpi-devel' respectively. < Required package is not arched, use < rpmlint shows an sqrt 'undefined-non-weak-symbol' warning, the library looks correctly linked with libm.so. 'unused-direct-shlib-dependency /usr/lib64/mpich/lib/libElSuiteSparse.so /usr/lib64/mpich/lib/libmpi.so.12' looks wrong, too. |
|
We should look into fixing the warnings if at all possible. |
|
This PR addresses: elemental-mpich.x86_64: E: invalid-soname /usr/lib64/mpich/lib/libpmrrr.so libpmrrr.so and elemental-mpich.x86_64: E: library-without-ldconfig-postin /usr/lib64/mpich/lib/libEl.so.86-dev I'm unsure about the rest of them. |
| target_link_libraries(pmrrr | ||
| ${MPI_C_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT} ${MATH_LIBS}) | ||
| endif() | ||
| set_target_properties(pmrrr PROPERTIES VERSION ${EL_VERSION_MINOR} SOVERSION ${EL_VERSION_MAJOR}) |
There was a problem hiding this comment.
What is up with the spacing here?
There was a problem hiding this comment.
looks like github. doesnt show up in vim.
versioning the pmrrr and ElSuiteSparse