PMRRR calls exit #196
Merged
PMRRR calls exit #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poulson
reviewed
Nov 19, 2016
external/pmrrr/src/plarre.c
Outdated
| fprintf(stderr,"No initial representation could be found.\n"); | ||
| exit(3); | ||
| return 3; | ||
| //exit(3); |
Member
There was a problem hiding this comment.
It is generally bad practice to leave the old code commented out since we have version control.
Also, are you ensuring that the returned 3 properly propagates?
Member
There was a problem hiding this comment.
Upon further review, modulo removing the commented out line, I approve this PR, as the only callsite asserts that the return value is zero.
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses another linter issue.