feat: Group alerts by owner #1809
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaffarano
commented
Feb 10, 2025
| @@ -38,12 +38,12 @@ class ElementaryCLI(click.MultiCommand): | |||
| "run-operation": run_operation, | |||
| } | |||
|
|
|||
| def list_commands(self, ctx): | |||
| return self._CMD_MAP.keys() | |||
| def list_commands(self, ctx) -> list[str]: | |||
There was a problem hiding this comment.
the changes here were because of some linting warnings from pyright I got
| @@ -88,11 +88,11 @@ def __init__( | |||
|
|
|||
| config = self._load_configuration() | |||
|
|
|||
| self.target_dir = self._first_not_none( | |||
| self.target_dir = str(self._first_not_none( | |||
There was a problem hiding this comment.
the changes here were because of some linting warnings from pyright I got
There was a problem hiding this comment.
Here is a WIP because I don't have a valid Teams user to test it, but I can finish it if you agree with the current implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of what I proposed in #1808. It is only focused on
Slack, but if you agree with what I did, I could also implement theTeamssupport.