Adds --s3-acl option to the cli to be able to set S3 report permissions. #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option allows to set a S3 Canned ACL value for the report.
Lawiss
temporarily deployed
to
elementary_test_env
GitHub Actions
Inactive
Lawiss
requested a deployment
to
elementary_test_env
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when uploading the report to S3, there is no specific permission set, thus it default to
private.This PR adds the
--s3-aclparameter to the CLI in order to be able to set an ACL option (list of possible values are listed here).This is useful to make the report publicly available when uploaded to the bucket.