Skip to content

Ele 4261 clickhouse cli integration #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 16, 2025
Merged

Ele 4261 clickhouse cli integration #1892

merged 8 commits into from
Apr 16, 2025

Conversation

michael-myaskovsky
Copy link
Contributor

@michael-myaskovsky michael-myaskovsky commented Apr 7, 2025 •
edited by github-actions bot
Loading

null

@linear Linear
Copy link

linear bot commented Apr 7, 2025

ELE-4261 Clickhouse CLI integration

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

👋 @michael-myaskovsky
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@michael-myaskovsky michael-myaskovsky force-pushed the ele-4261-clickhouse-cli-integration branch from 007d37d to 2f7331a Compare April 10, 2025 09:39
ofek1weiss
ofek1weiss reviewed Apr 14, 2025
View reviewed changes
elementary/monitor/dbt_project/macros/get_test_results.sql Outdated
@@ -95,8 +219,6 @@

{%- if (test_type == 'dbt_test' and status in ['fail', 'warn']) or (test_type != 'dbt_test' and status in elementary_tests_allowlist_status) -%}
{% set test_rows_sample = elementary_cli.get_test_rows_sample(test.result_rows, test_result_rows_agate.get(test.id)) %}
{# Dimension anomalies return multiple dimensions for the test rows sample, and needs to be handle differently. #}
{# Currently we show only the anomalous for all of the dimensions. #}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove the comments?

@michael-myaskovsky michael-myaskovsky force-pushed the ele-4261-clickhouse-cli-integration branch from 13fafae to b0f4a2d Compare April 16, 2025 09:52
@michael-myaskovsky michael-myaskovsky merged commit ee0329c into master Apr 16, 2025
4 checks passed
@michael-myaskovsky michael-myaskovsky deleted the ele-4261-clickhouse-cli-integration branch April 16, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek1weiss ofek1weiss ofek1weiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-myaskovsky @ofek1weiss