Skip to content

Conversation

@meisenzahl
Copy link
Member

@meisenzahl meisenzahl commented Jan 8, 2022

Review Checklist

This checklist is used by reviewers, so you don't need to fill in by yourself.

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

@meisenzahl
Copy link
Member Author

I would like to transfer my existing apps to my own domain name. Would be great if this would work 😊

@meisenzahl meisenzahl marked this pull request as ready for review January 8, 2022 13:47
@meisenzahl meisenzahl requested a review from a team as a code owner January 8, 2022 13:47
@danirabbit
Copy link
Member

hm, so instead of removing the old file, we need to rebuild that package with end-of-life-rebase as an argument to flatpak builder: https://docs.flatpak.org/en/latest/flatpak-command-reference.html?highlight=end-of-life-rebase

I think you need to file a new feature request against this repo where you can add end-of-life and end-of-life properties to the json file. And I'm also not sure if the Flatpak builder action supports these parameters, so we might need an upstream feature request there as well

@meisenzahl meisenzahl marked this pull request as draft January 9, 2022 06:47
@ryonakano
Copy link
Member

I think we need to separate PRs for EOL and new .json file to pass CI, but the author seems to be inactive these days

@ryonakano
Copy link
Member

Closing due to inactivity. Feel free to reopen if you still want to publish your app to AppCenter.

@ryonakano ryonakano closed this Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants