Skip to content

Conversation

@sammarxz
Copy link

@sammarxz sammarxz commented Nov 25, 2024

pomerode-preview

Review Checklist

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • Custom colors meet WCAG A contrast or greater
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

Review Checklist

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

@sammarxz sammarxz requested a review from a team as a code owner November 25, 2024 13:33
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for your submission. It looks like your app was build against the GNOME Runtime. Apps in AppCenter must be build against the elementary runtime. See publishing requirements for this and other requirements: https://docs.elementary.io/develop/appcenter/publishing-requirements

@ryonakano
Copy link
Member

@sammarxz The above issue has been resolved by sammarxz/pomerode#1, but you need to create a new release to include these changes and update the commit and version in applications/com.github.sammarxz.pomerode.json in this branch.

Also, your app uses Adwaita stylesheet which is not accepted (see #429 (review)). However, you don't need to subclass Gtk.Application these days and just calling Granite.init () in the startup () method of your application class (like this) should work.

@danirabbit
Copy link
Member

I'm going to close this since there's been no movement since January. Please feel free to resubmit if you can resolve the remaining issues that Ryo pointed out!

@danirabbit danirabbit closed this Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants