Skip to content

Conversation

@xchan14
Copy link
Contributor

@xchan14 xchan14 commented Apr 6, 2025

  • Update Settings from dialog to popover
  • Update runtime version to 8.1

Review Checklist

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

@xchan14 xchan14 requested a review from a team as a code owner April 6, 2025 20:20
@ryonakano
Copy link
Member

Maybe the release date of 1.2.0 would be 2024-03-24 (or 2024-03-23 depending on your timezone) instead of 2024-03-03 as far as seeing the creation date of it, but I won't take care because this relates to the previous release note anyways.

diff --git a/data/io.github.xchan14.larawan.metainfo.xml.in b/data/io.github.xchan14.larawan.metainfo.xml.in
index aeaeaf4..92c55aa 100644
--- a/data/io.github.xchan14.larawan.metainfo.xml.in
+++ b/data/io.github.xchan14.larawan.metainfo.xml.in
@@ -43,6 +43,23 @@


  <releases>
+    <release version="1.3.0" date="2025-04-07">
+      <description>
+        <ul>
+          <li>Changed Settings from dialog to popover</li>
+          <li>Updated runtime version</li>
+        </ul>
+      </description>
+    </release>
+
+    <release version="1.2.0" date="2024-03-03">
+      <description>
+        <ul>
+          <li>Updated Settings dialog</li>
+        </ul>
+      </description>
+    </release>
+
     <release version="1.1.1" date="2024-03-03">
       <description>
         <ul>

@ryonakano
Copy link
Member

I've opened some PRs that fixes things I found while reviewing, but these are really tiny things and I don't mean changes requests.

Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1.3.0 release. App launches, does what it says, and no problematic changes found.

@xchan14 Thank you for updating new release! Should I wait for merging this release if you possibly mean to merge my PRs and release them soon as 1.3.1? Or should I go ahead if you merge them later?

@xchan14
Copy link
Contributor Author

xchan14 commented Apr 8, 2025

Hello, I created a new pull request for v1.3.1. Let's merge that one instead.

@xchan14 xchan14 closed this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants