Skip to content

Conversation

@stsdc
Copy link
Member

@stsdc stsdc commented Jun 21, 2025

This is a continuation of #580.
The GdkPixbuf deprecation will be removed in the next version.

Review Checklist

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

@stsdc stsdc requested a review from a team as a code owner June 21, 2025 15:39
@stsdc
Copy link
Member Author

stsdc commented Jun 21, 2025

It's building well via GNOME Builder, but not when I'm running

flatpak-builder build io.github.stsdc.gadget_clock.json --user --install --force-clean

The gtkmm.json is the same as for Gnote.

@ryonakano
Copy link
Member

It's building well via GNOME Builder, but not when I'm running

flatpak-builder build io.github.stsdc.gadget_clock.json --user --install --force-clean

@stsdc I opened stsdc/gadget_clock#2 to fix that issue. Otherwise there are no issues that blocks publishing your app.

Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stsdc I'm sorry, I overtook the following warning when running flatpak-build in the previous review. You need to choose another categories exist in the registered categories (main or additional) other than Other.

WARNING: Failed to validate desktop file /home/user/work/gadget_clock/builddir/export/share/applications/io.github.stsdc.gadget_clock.desktop: /home/user/work/gadget_clock/builddir/export/share/applications/io.github.stsdc.gadget_clock.desktop: error: value "GTK;Utility;Other;" for key "Categories" in group "Desktop Entry" contains an unregistered value "Other"; values extending the format should start with "X-"

@ztefn
Copy link
Contributor

ztefn commented Jun 23, 2025

Clock seems appropriate:

Additional Category Description Related Categories
Clock A clock application/applet Utility

😊

Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ryonakano ryonakano merged commit 800bdc3 into main Jun 23, 2025
4 checks passed
@ryonakano ryonakano deleted the io.github.stsdc.gadget_clock.json branch June 23, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants