com.github.libredeb.hashit submission

[libredeb]

new intuitive and simple hash checker app for elementary OS

Review Checklist

• App opens
• Does what it says
• Categories match

AppData

• Name is unique and non-confusing
  • There used to be a similar app named "Hash It" by artemanufrij but it has never been updated/released after AppCenter migrates from Debian packaging to Flatpak, so I (ryonakano) think fine.
• Matches description
• Matches screenshot
• Launchable tag with matching ID
• Release tag with matching version and YYYY-MM-DD date
• OARS info matches

Flatpak

• Uses elementary runtime
• Sandbox permissions are reasonable

[ryonakano]

Thank you for your submission! There are a few tiny issues I'd like you to resolve before publishing your app:

Requirements

• Your app name should be unified. There are two notations in your code: Hashit and Hash-it.
• You must NOT use the org.elementaryos developer id. That's the developer id we elementary, Inc. use and you should use another unique id instead.
  • Mentioning code
  • Documentation
• We don't recommend you to say your app is designed for elementary OS, because all apps on AppCenter are designed for elementary OS.
  • Mentioning code (and the man page too)
  • Documentation
• The help URL specified in your metainfo file not found.
  • Mentioning code
• The Actions specified in your desktop file not found, resulting the following warning when running flatpak-builder:

  WARNING: Failed to validate desktop file /home/user/work/hash-it/builddir/export/share/applications/com.github.libredeb.hashit.desktop: /home/user/work/hash-it/builddir/export/share/applications/com.github.libredeb.hashit.desktop: error: action "AboutDialog" is defined, but there is no matching "Desktop Action AboutDialog" group
  

  • Mentioning code
• Your icons missing on Flatpak builds. I proposed libredeb/hash-it#3 and libredeb/hash-it#4 to fix this.

Recommends

• I personally don't recommend you to use the com.github.* RDNN because it's no longer acceptable on Flathub.
  • Although we still accept com.github.* differing from Flathub, using this RDNN means you won't be able to submit your app on Flathub if you would like to do so in the future.
  • Documentation
• The Comment in your desktop file is noun, but we recommend to follow the Name is a(n) GenericName that helps you Comment. formula.
  • Mentioning code
  • Documentation
• You should use a more descriptive screenshot. I think it's not intuitive that what your app does from the current screenshot. Maybe you can take a screenshot after hashing?
  • Mentioning code
• You should watch your repository as a maintainer so that you don't miss activities from contributors.

[libredeb]

@ryonakano all done! Could you validate if all changes I maded it in release/v0.1.3 branch are ok? And if I forgot something along the way?

[libredeb]

@ryonakano I think that the other "hashit" app is outdated and unmaintained. I hope this will not be a problem (that another app with a similar name exists) but even my application has more features and uses GTK4.

[ryonakano]

@libredeb Thank you for your quick fix! Almost looks good but I request one small change.

You don't need to write the whole of Name is a(n) GenericName that helps you Comment. formula in the Comment section of your desktop file; just Validate the integrity of files is enough, like this:

-Comment=Hash-it is an hash checker tool that helps you to validate the integrity of files
+Comment=Validate the integrity of files

(Sorry for my poor English to have led you being misunderstand)

And regarding to the app name, I totally agree with you 👍

[libredeb]

Thanks again @ryonakano I'm from Argentina and my english isnt good either haha. All changes done! Can you verify that everything is as planned?

[ryonakano]

LGTM, congratulations on your app publishment!