Skip to content

Conversation

@teamcons
Copy link
Contributor

@teamcons teamcons commented Jun 29, 2025

Fix the oversight

Review Checklist

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

@teamcons teamcons requested a review from a team as a code owner June 29, 2025 09:44
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Request

Suggestion (Not blocking issues)

  • There are no such color type primary-text available in the fd.o's branding specification.
        <branding>
          <color type="primary" scheme_preference="light">#fff394</color>
          <color type="primary-text" scheme_preference="light">#fff</color>
          <color type="primary" scheme_preference="dark">#ad5f00</color>
          <color type="primary-text" scheme_preference="dark">#000</color>
        </branding>
  • The following URL not found
        <url type="translate">https://github.com/ellie-commons/reminduck/blob/main/po/README.md</url>

Question

  • The following finish-args was removed from manifest for Flathub but still alive in the one for AppCenter. Is there any reason for this difference?
    -  # Required to do a quack sound
    -  - '--socket=pulseaudio'

@teamcons teamcons closed this Jun 30, 2025
@teamcons teamcons reopened this Jun 30, 2025
@teamcons
Copy link
Contributor Author

@ryonakano this should be OK now

Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ryonakano ryonakano merged commit 0c57ede into elementary:main Jun 30, 2025
4 checks passed
@teamcons
Copy link
Contributor Author

Thank you so so much!
Danielle saw an obvious error, but merged the first PR regardless. And since, im in panic to get the fix merged, else anyone who installs reminduck before this one has a broken autostart - and thus cant rely on its function at all

@teamcons teamcons deleted the patch-3 branch June 30, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants