-
-
Notifications
You must be signed in to change notification settings - Fork 56
Update io.github.ellie_commons.reminduck.json #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes Request
- Shouldn't you add release notes?
- Your metainfo file is missing the launchable tag
Suggestion (Not blocking issues)
- There are no such color type
primary-textavailable in the fd.o's branding specification.<branding> <color type="primary" scheme_preference="light">#fff394</color> <color type="primary-text" scheme_preference="light">#fff</color> <color type="primary" scheme_preference="dark">#ad5f00</color> <color type="primary-text" scheme_preference="dark">#000</color> </branding>
- The following URL not found
<url type="translate">https://github.com/ellie-commons/reminduck/blob/main/po/README.md</url>
Question
- The following finish-args was removed from manifest for Flathub but still alive in the one for AppCenter. Is there any reason for this difference?
- # Required to do a quack sound - - '--socket=pulseaudio'
|
@ryonakano this should be OK now |
ryonakano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
Thank you so so much! |
Fix the oversight
Review Checklist
AppData
Flatpak