Skip to content

Conversation

@dar5hak
Copy link
Contributor

@dar5hak dar5hak commented Jul 3, 2025

Badger is now v5! 🎉

The biggest changes are:

  • It's now GTK4
  • It uses the background portal to autostart instead of manually installing a .desktop file

And there are some nice UI updates as well.

Most of this is thanks to @teamcons. They're awesome.

Review Checklist

This checklist is used by reviewers, so you don't need to fill in by yourself.

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

@dar5hak dar5hak requested a review from a team as a code owner July 3, 2025 16:21
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice revamp! I have the two following suggestions but they are not review points required for submission actually, so I'll approve your PR.

Optional Suggestions

  • vapi/config.vapi
    • You don't need this file; it's not used anywhere.
  • com.github.elfenware.badger.flathub.yml
    • FYI use of --socket=session-bus is limited on Flatpak: Documentation
    • This file is not used for AppCenter builds so we don't care for now, but the same limitation goes if you use this arg in the elementary manifest too

@ryonakano ryonakano merged commit c4b642b into elementary:main Jul 5, 2025
4 checks passed
@teamcons
Copy link
Contributor

teamcons commented Jul 5, 2025

Hi Ryo!
The flathub manifest is a draft i added at some point. It is half baked - and would either be deleted or worked upon depending if theres interest to have badger there as well.

@ryonakano
Copy link
Member

The flathub manifest is a draft i added at some point. It is half baked - and would either be deleted or worked upon depending if theres interest to have badger there as well.

That's fine, I just wrote the suggestion as FYI in case you two might submit this manifest as it is for review on Flathub.

But it looks like previously Badger published on Flathub but archived soon? flathub/flathub#2454 (comment)

Anyway, whether to publish an app on Flathub too or not is up to its maintainers and you should discuss with @dar5hak in the repository of Badger.

@dar5hak
Copy link
Contributor Author

dar5hak commented Jul 5, 2025

Yeah, the historical context is that I published it at the suggestion of a contributor, but then thought anyone can get it from AppCenter anyway, so why keep two copies? But @teamcons make a good point that the discoverability is much higher there. So we'll try and release it there again.

@dar5hak
Copy link
Contributor Author

dar5hak commented Jul 5, 2025

Thank you for the review though! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants