-
-
Notifications
You must be signed in to change notification settings - Fork 56
Update jorts to 3.3.0 #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ryonakano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be pedantic though, I suppose you shouldn't remove the name of the original author, Lains, from the copyright holder text if the source code is originally written by them and not written by you from scratch (I think the copyright header is not a thing that can easily "unify").
But this is out of scope of the review process so approving.
What do you mean ?
Though yes i could add it in the short, 4-lines, one (with "SPDX-FileCopyrightText:"), but i am already unsure if both us and ellie-commons arent too much already i removed the AUTHORS file because it seemed redundant, and other projects dont have it, but thats easy to restore (without my personal info) im not sure how this be done properly tbh, but i definitively dont want to ever erase her contribution from it |
|
@teamcons I highly recommend this free course from Linux Foundation about software licensing basics. It will explain how to use copyright and license headers etc https://training.linuxfoundation.org/training/open-source-licensing-basics-for-software-developers/ |
I mean the changes that ryo@b760m:~/work/ellie-commons/jorts (main =)$ git diff 72af4ffa4747218ec83eaf215b62a7e3075f4ecb..6a2b878e4d9db5e56f05f17fe2562faafa41cfdf | grep Lains
-Lains <[email protected]>
"Ito ay isang tinidor ng isang lumang bersyon ng \"NoteJot \" ni Lainsce at "
"यह Lainsce द्वारा \"नोटजोट \" के एक पुराने संस्करण का एक कांटा है और उसके काम के बिना "
"questa è una forchetta di una vecchia versione di \"Notejot\" di Lainsce e "
"Dit is een vork van een oude versie van \"NoteJot\" door Lainsce en zou niet "
"Toto je vidlica starej verzie \"Notejot\" od Lainsce a bez jej práce by "
"Detta är en gaffel av en gammal version av \"Notejot\" av Lainsce och skulle "
* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
ryo@b760m:~/work/ellie-commons/jorts (main =)$ |
|
Yeah initially there was the superlong copyright wall of text |
Reminduck will follow very soon
We've revived Picker btw: https://github.com/ellie-commons/cherrypick
But we cant contact the dev, so this is waiting for a new icon (we have someone new who wanna contribute :) )