Skip to content

Conversation

@teamcons
Copy link
Contributor

@teamcons teamcons commented Jul 6, 2025

Reminduck will follow very soon
We've revived Picker btw: https://github.com/ellie-commons/cherrypick
But we cant contact the dev, so this is waiting for a new icon (we have someone new who wanna contribute :) )

@teamcons teamcons requested a review from a team as a code owner July 6, 2025 09:50
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be pedantic though, I suppose you shouldn't remove the name of the original author, Lains, from the copyright holder text if the source code is originally written by them and not written by you from scratch (I think the copyright header is not a thing that can easily "unify").

But this is out of scope of the review process so approving.

@ryonakano ryonakano merged commit 70f0e5e into elementary:main Jul 6, 2025
4 checks passed
@teamcons
Copy link
Contributor Author

teamcons commented Jul 6, 2025

This would be pedantic though, I suppose you shouldn't remove the name of the original author, Lains, from the copyright holder text

What do you mean ?
She is still in the long form one:

  • Copyright (c) 2017-2024 Lains
  • Copyright (c) 2025 Stella, Charlie, (teamcons on GitHub) and the Ellie_Commons community

Though yes i could add it in the short, 4-lines, one (with "SPDX-FileCopyrightText:"), but i am already unsure if both us and ellie-commons arent too much already
She is in the README. Im not sure how to add her to metainfo

i removed the AUTHORS file because it seemed redundant, and other projects dont have it, but thats easy to restore (without my personal info)

im not sure how this be done properly tbh, but i definitively dont want to ever erase her contribution from it
Please let me know how it would be done properly

@teamcons teamcons deleted the patch-3 branch July 6, 2025 14:11
@danirabbit
Copy link
Member

@teamcons I highly recommend this free course from Linux Foundation about software licensing basics. It will explain how to use copyright and license headers etc https://training.linuxfoundation.org/training/open-source-licensing-basics-for-software-developers/

@ryonakano
Copy link
Member

ryonakano commented Jul 8, 2025

This would be pedantic though, I suppose you shouldn't remove the name of the original author, Lains, from the copyright holder text

What do you mean ?

I mean the changes that Copyright (c) 2017-2024 Lains lines in the copyright headers in some files was removed in 3.3.0 (which you seemed to revive her name already in latest main branch though):

ryo@b760m:~/work/ellie-commons/jorts (main =)$ git diff 72af4ffa4747218ec83eaf215b62a7e3075f4ecb..6a2b878e4d9db5e56f05f17fe2562faafa41cfdf | grep Lains
-Lains <[email protected]>
 "Ito ay isang tinidor ng isang lumang bersyon ng \"NoteJot \" ni Lainsce at "
 "यह Lainsce द्वारा \"नोटजोट \" के एक पुराने संस्करण का एक कांटा है और उसके काम के बिना "
 "questa è una forchetta di una vecchia versione di \"Notejot\" di Lainsce e "
 "Dit is een vork van een oude versie van \"NoteJot\" door Lainsce en zou niet "
 "Toto je vidlica starej verzie \"Notejot\" od Lainsce a bez jej práce by "
 "Detta är en gaffel av en gammal version av \"Notejot\" av Lainsce och skulle "
 * Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
-* Copyright (c) 2017-2024 Lains
ryo@b760m:~/work/ellie-commons/jorts (main =)$

@teamcons
Copy link
Contributor Author

teamcons commented Jul 8, 2025

Yeah initially there was the superlong copyright wall of text
I saw a short form existed, and thought it would be cleaner to use it. So i replaced it
But after you mentioned this, i looked up if you can mention several holders, and it indeed works. So i went through to add her back.
There is currently little code left from her, but still modern jorts owes to her, so i want to honour that root most i can
Im just pretty much out of my depth in everything i do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants