Skip to content

Conversation

@teamcons
Copy link
Contributor

@teamcons teamcons commented Jul 23, 2025

Ryo's nitpick on a missing space made me look for an opportunity for a new release, because it is the kind of detail you cant unsee

Their PR kicked me into taking care of a deprecated widget and doing finally a release with all the polish. If Cherrypick ends up unmaintained at least it can hold a solid while now

(and now i realize i left it at 8 instead of 8.2... Hope theres not too much missing out)

Review Checklist

This checklist is used by reviewers, so you don't need to fill in by yourself.

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

Ryo's nitpick on a missing space made me look for an opportunity for a new release, because it is the kind of detail you cant unsee

Their PR kicked me into taking care of a deprecated widget and doing finally a release with all the polish. If Cherrypick ends up unmaintained at least it can hold a solid while now

(and now i realize i left it at 8 instead of 8.2... Hope theres not too much missing out)
@teamcons teamcons requested a review from a team as a code owner July 23, 2025 18:32
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release date of 2.1.0 seems to be just copied and pasted from 2.0.1. I won't block publishing your release this time though, because there are no other problems in 2.1.0 and it's foolish to let you create another release to address this.

+    <release date="2025-07-14" version="2.1.0">

@ryonakano
Copy link
Member

(and now i realize i left it at 8 instead of 8.2... Hope theres not too much missing out)

It's fine if you're using 8.x version of the platform at the moment. Note that using 8.2 at the moment would encounter the crash I fixed in elementary/granite#893

@ryonakano ryonakano merged commit e745780 into elementary:main Jul 23, 2025
4 checks passed
@teamcons teamcons deleted the patch-7 branch July 24, 2025 09:43
@teamcons
Copy link
Contributor Author

The release date of 2.1.0 seems to be just copied and pasted from 2.0.1. I won't block publishing your release this time though, because there are no other problems in 2.1.0 and it's foolish to let you create another release to address this.

I have been cursed by a mildly evil wizard to always miss a detail or two, and it is very irritating.

Thank you Ryo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants