Skip to content

Conversation

@teamcons
Copy link
Contributor

@teamcons teamcons commented Sep 12, 2025

Review Checklist

This checklist is used by reviewers, so you don't need to fill in by yourself.

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

@teamcons teamcons requested a review from a team as a code owner September 12, 2025 11:51
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good release!

Just on a side note, please get in the habit of pushes to branches and not to main. The commit history is very messy and the commit messages are not very high quality. This makes it a lot harder to keep track of changes and in the future when you might have to understand why a change was made or even revert a change this will make it a lot harder for future contributors or your future self

@danirabbit danirabbit merged commit 564bc08 into elementary:main Sep 12, 2025
4 checks passed
@teamcons teamcons deleted the patch-6 branch September 12, 2025 21:21
@teamcons
Copy link
Contributor Author

Looks like a good release!

Just enough so RollIt can stay as is for a while
I never really intend to go very far when porting old apps - just make them not crusty is enough. The point is so people dont install Granite apps and then go "ew, the OS is good but the ecosystem is all stuff that looks old/doesnt work"
Rollit though is used when i GM :p

Just on a side note, please get in the habit of pushes to branches and not to main. The commit history is very messy and the commit messages are not very high quality. This makes it a lot harder to keep track of changes and in the future when you might have to understand why a change was made or even revert a change this will make it a lot harder for future contributors or your future self

Wouldnt PRs add their commit history to main branch too?
If not, yeh, will try. Moreso for the discipline and for when contributing to active projects, but i dont think anyone would really care to help

@danirabbit
Copy link
Member

Wouldnt PRs add their commit history to main branch too?

Not if you use squash merge!

I don't think anyone would care to help

You won't know until you try :) I personally would be happy to do some reviews if they're requested for the commons dev team. I think other people would also be happy to if they're getting the notification in their inbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants