Skip to content

Conversation

@teamcons
Copy link
Contributor

@teamcons teamcons commented Oct 31, 2025

Tidier app to go with the new background progress thingie

Review Checklist

This checklist is used by reviewers, so you don't need to fill in by yourself.

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

Tidier app to go with the new background progress thingie
@teamcons teamcons requested a review from a team as a code owner October 31, 2025 15:18
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

Something I noticed is you've added a withdraw right before a send with the same ID. You don't need to do this and actually you shouldn't do this because when you send with the same ID it will replace automatically https://docs.elementary.io/develop/apis/notifications#replace

@danirabbit danirabbit merged commit d0b5939 into elementary:main Oct 31, 2025
4 checks passed
@teamcons
Copy link
Contributor Author

This looks good!

Something I noticed is you've added a withdraw right before a send with the same ID. You don't need to do this and actually you shouldn't do this because when you send with the same ID it will replace automatically https://docs.elementary.io/develop/apis/notifications#replace

there must be a bug somewhere with this, because the withdraw was added on purpose.
I noticed when working on badger that notifications for the same reminder would pile up, and there was an older ticket mentioning this.

@teamcons teamcons deleted the patch-2 branch October 31, 2025 20:36
@danirabbit
Copy link
Member

@teamcons hmm are you running latest? I thought we support replaces in the indicator since a long time. If not if you can confirm an issues report that would be helpful as well and we can add it to the next OS project board

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants