Sidebar History #278
Open
Sidebar History #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypw
reviewed
Feb 11, 2025
| @@ -0,0 +1,122 @@ | |||
| /*- | |||
| * Copyright 2018-2021 elementary, Inc. (https://elementary.io) | |||
jeremypw
reviewed
Feb 11, 2025
| history_list.remove_all (); | ||
| }); | ||
|
|
||
| var headerbar = new Adw.HeaderBar () { |
Collaborator
There was a problem hiding this comment.
I think maybe we should hide the close button in this header. I thought it would close the history but in fact it unexpectedly closed the whole window. Should replace with a "close sidebar" button? On the other hand other apps do have the close button inside the sidebar but there the sidebar is not a temporary overlay so I am not sure what to do. @danirabbit please advise. Another solution would be to have the sidebar on the right.
jeremypw
reviewed
Feb 11, 2025
Collaborator
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
A couple of in-line comments.
Also, the history seems to be held in two separate models - one in MainWindow and one in HistorySidebar. Is this necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #276