Make Drag-n-Drop events less hacky #405
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypw
reviewed
Jun 29, 2019
core/Model/CalendarModel.vala
Outdated
| return events; | ||
| } | ||
|
|
||
| private static int search_rid (E.CalComponent a, string? rid) { |
Collaborator
There was a problem hiding this comment.
This would normally be named compare_id or similar. DId you mean to name the following "get_event ()" this? It would make more sense.
Collaborator
|
Needs deb-packaging updating in order to pass Travis CI (libmayacalendar0.symbols). |
jeremypw
reviewed
May 15, 2020
added 2 commits
May 15, 2020 18:27
Collaborator
|
You need to merge |
Collaborator
|
@tintou Converting to draft as there are conflicts, CI issues and no recent activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That
drag_componentin the CalendarModel made no sense