SourceDialog: make a dialog#840
Merged
Merged
Conversation
jeremypw
approved these changes
Jul 22, 2025
jeremypw
left a comment
jeremypw
left a comment
Collaborator
There was a problem hiding this comment.
Code looks good and runs as expected (although I did not actually create a new calendar).
To my eye the vertical spacing looks a little cramped but will leave that to you.
danirabbit
enabled auto-merge (squash)
July 22, 2025 14:11
Member
Author
|
Yeah spacing is terrible here. Gonna get it in a follow up. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like this was a dialog and then at some point became a popover subpage? Forms should definitely be a new dialog and not a popover since popovers can be easily/accidentally dismissed
While we're here, DRY the edit/create source function